Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve Aleph VMs automatic restarts #750

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

nesitor
Copy link
Member

@nesitor nesitor commented Feb 13, 2025

Confidential VMs are restarted automatically

Related ClickUp, GitHub or Jira tickets : ALEPH-383

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.
  • Documentation has been updated regarding these changes.
  • Dependencies update in the project.toml have been mirrored in the Debian package build script packaging/Makefile

Changes

Problem: On Ubuntu 24.04 OS version, a new service called needrestart restart some services automatically and this also resets some confidential VMs that cannot init again as we don't store the password key.

Solution: Add a rule on needrestart service to skip the restart on aleph services.

How to test

Install the version on a CRN with some instances inside and do a manual package update.

…t` restart some services automatically and this also resets some confidential VMs that cannot init again as we don't store the password key.

Solution: Add a rule on `needrestart` service to skip the restart on aleph services.
@nesitor nesitor requested a review from olethanh February 13, 2025 13:05
@nesitor nesitor self-assigned this Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.90%. Comparing base (97f07f2) to head (c9b3286).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #750   +/-   ##
=======================================
  Coverage   62.90%   62.90%           
=======================================
  Files          74       74           
  Lines        6540     6540           
  Branches      541      541           
=======================================
  Hits         4114     4114           
  Misses       2262     2262           
  Partials      164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nesitor nesitor merged commit cd8443e into main Feb 13, 2025
22 checks passed
@nesitor nesitor deleted the andres-fix-stop_service_automatic_restart branch February 13, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants