Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression: Monitoring of payment stream #749

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

olethanh
Copy link
Collaborator

Problem: in monitoring_payment_task
the check of stream payment was not done

Regression introduced in #726

Related ClickUp, GitHub or Jira tickets : none

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • [:(] All new code is covered by relevant tests.
  • Documentation has been updated regarding these changes.
  • Dependencies update in the project.toml have been mirrored in the Debian package build script packaging/Makefile

Problem: in monitoring_payment_task
the check of stream payment was not done

Regression introduced in #726
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 62.90%. Comparing base (b020227) to head (788d0cf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/aleph/vm/orchestrator/tasks.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #749      +/-   ##
==========================================
- Coverage   62.91%   62.90%   -0.01%     
==========================================
  Files          74       74              
  Lines        6541     6540       -1     
  Branches      541      541              
==========================================
- Hits         4115     4114       -1     
  Misses       2262     2262              
  Partials      164      164              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nesitor nesitor merged commit 97f07f2 into main Feb 13, 2025
20 of 22 checks passed
@nesitor nesitor deleted the ol-fix-stream-payment-check branch February 13, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants