Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instance ip4 network stopping (nat) #742

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Fix instance ip4 network stopping (nat) #742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/aleph/vm/pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,11 @@
def teardown(self) -> None:
"""Stop the VM pool and the network properly."""
if self.network:
self.network.teardown()
# self.network.teardown()
# FIXME Temporary disable tearing down the network
# Fix issue of persistent instances running inside systemd controller losing their ipv4 nat access
# upon supervisor restart or upgrade.
pass

Check warning on line 88 in src/aleph/vm/pool.py

View check run for this annotation

Codecov / codecov/patch

src/aleph/vm/pool.py#L88 

Added line #L88 was not covered by tests

async def create_a_vm(
self, vm_hash: ItemHash, message: ExecutableContent, original: ExecutableContent, persistent: bool
Expand Down
Loading