Display proper error for message not found #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
or not being downloadable Problem: When calling an program on a CRN, whose message the CRN couldn’t reach, it returned the error ``` 500: Unhandled error during initialisation ``` instead of a proper explaination error Solution: Catch that error. Catch also the other possible error when downloading This also now works when failing to download a runtime or volume
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #738 +/- ##
==========================================
- Coverage 62.81% 62.76% -0.05%
==========================================
Files 70 70
Lines 6314 6319 +5
Branches 516 517 +1
==========================================
Hits 3966 3966
- Misses 2190 2195 +5
Partials 158 158 ☔ View full report in Codecov by Sentry. |
Psycojoker
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
or not being downloadable
Related ClickUp, GitHub or Jira tickets : ALEPH-353
Problem:
When calling an program on a CRN, whose message the CRN couldn’t reach, it returned the error
instead of a proper explanation error
Solution:
Catch that error. Catch also the other possible error when downloading
This also now works when failing to download a runtime or volume
testing
Call your CRN via http with an invalid item hash