Implement GPU Support #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: Implement GPU assignation feature that will be pass-though to QEmu VMs with native performance.
nesitor
force-pushed
the
andres-feature-implement_gpu_support
branch
from
a9f85eb to
24516a2
Compare
nesitor
force-pushed
the
andres-feature-implement_gpu_support
branch
from
891ed73 to
60b2491
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## proto-add-gpu-listing #728 +/- ##
=========================================================
- Coverage 62.79% 62.46% -0.33%
=========================================================
Files 72 73 +1
Lines 6343 6424 +81
Branches 514 528 +14
=========================================================
+ Hits 3983 4013 +30
- Misses 2199 2249 +50
- Partials 161 162 +1 ☔ View full report in Codecov by Sentry. |
nesitor
force-pushed
the
andres-feature-implement_gpu_support
branch
from
0c58cad to
ba1fc9d
Compare
olethanh
requested changes
Dec 9, 2024
There was a problem hiding this comment.
I already add a few comments and concerns. I haven't been able to test it fully yet.
aleph-vmrefuse to launch properly as it is missing migration for the newly added database column. This is going to be a problem in prod.- The test server I use at the moment don't have a GPU, it's going to be added on Thursday.
nesitor
force-pushed
the
andres-feature-implement_gpu_support
branch
from
c9b717e to
70b7390
Compare
olethanh
approved these changes
Dec 9, 2024
olethanh
force-pushed
the
andres-feature-implement_gpu_support
branch
from
6a12504 to
d919116
Compare
|
I have tested with the CRN Andres put a my disposal and it seems to be working |
nesitor
force-pushed
the
andres-feature-implement_gpu_support
branch
from
5f2579a to
11141af
Compare
nesitor
added a commit
that referenced
this pull request
Dec 17, 2024
* Problem: If a user wants to assign a GPU to a QEmu VM he cannot do it. Solution: Implement GPU assignation feature that will be pass-though to QEmu VMs with native performance. * Fix: Solved code quality issues * Fix: Solved compilation issue and fixed gpu logic. * Fix: Solved issue getting already running executions with GPU * Fix: Expose GPU support option in `status/config` endpoint * Fix: Applied some code review suggestions * Add migration * Fix: Allow to use the notify endpoint for GPU instances also. * Fix: Remove migration duplicity. * Fix: Changes DB initialization order to ensure that DB always exists before running the migrations. * Fix: Updated migration to only insert the column if isn't inside. --------- Co-authored-by: Olivier Le Thanh Duong <olivier@lethanh.be>
nesitor
added a commit
that referenced
this pull request
Feb 3, 2025
* Problem: If a user wants to assign a GPU to a QEmu VM he cannot do it. Solution: Implement GPU assignation feature that will be pass-though to QEmu VMs with native performance. * Fix: Solved code quality issues * Fix: Solved compilation issue and fixed gpu logic. * Fix: Solved issue getting already running executions with GPU * Fix: Expose GPU support option in `status/config` endpoint * Fix: Applied some code review suggestions * Add migration * Fix: Allow to use the notify endpoint for GPU instances also. * Fix: Remove migration duplicity. * Fix: Changes DB initialization order to ensure that DB always exists before running the migrations. * Fix: Updated migration to only insert the column if isn't inside. --------- Co-authored-by: Olivier Le Thanh Duong <olivier@lethanh.be>
nesitor
added a commit
that referenced
this pull request
Feb 3, 2025
* Add GPU list to /about/usage/system * Fix: Use created specified class. * Fix: Added GPU resources to the main pool and exposed it on the endpoint. * Fix: Solve code quality issues. * Fix: Improve code organization and structure. * Fix: Fixed existing tests and add new test case. * Implement GPU Support (#728) * Problem: If a user wants to assign a GPU to a QEmu VM he cannot do it. Solution: Implement GPU assignation feature that will be pass-though to QEmu VMs with native performance. * Fix: Solved code quality issues * Fix: Solved compilation issue and fixed gpu logic. * Fix: Solved issue getting already running executions with GPU * Fix: Expose GPU support option in `status/config` endpoint * Fix: Applied some code review suggestions * Add migration * Fix: Allow to use the notify endpoint for GPU instances also. * Fix: Remove migration duplicity. * Fix: Changes DB initialization order to ensure that DB always exists before running the migrations. * Fix: Updated migration to only insert the column if isn't inside. --------- Co-authored-by: Olivier Le Thanh Duong <olivier@lethanh.be> * Fix: Solve test code quality issues. --------- Co-authored-by: Andres D. Molins <amolinsdiaz@yahoo.es> Co-authored-by: Olivier Le Thanh Duong <olivier@lethanh.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Jira tickets : ALEPH-314
Self proofreading checklist
packaging/MakefileHow to test
Create a QEmu VM with assigned GPUs and check that you can use it inside the Qemu VM