Problem: IGNORE_TRACEBACK_FROM_DIAGNOSTICS broken #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #713 +/- ##
=======================================
Coverage 62.58% 62.58%
=======================================
Files 69 69
Lines 6140 6140
Branches 496 496
=======================================
Hits 3843 3843
Misses 2147 2147
Partials 150 150 ☔ View full report in Codecov by Sentry. |
Psycojoker
approved these changes
Oct 29, 2024
Symptom: The CustomError from the diagnostics VM was printed even if if IGNORE_TRACEBACK_FROM_DIAGNOSTICS was set to True (the default) Analysis: This was caused by the refactoring of the fastapi_example/main.py file done in fe9235a Which changed the output used to detect the error to catch Solution: Fix detection string
olethanh
force-pushed
the
ol-IGNORE_TRACEBACK_FROM_DIAGNOSTICS-broken
branch
from
183925c to
fa0080e
Compare
Antonyjin
pushed a commit
that referenced
this pull request
Nov 19, 2024
Symptom: The CustomError from the diagnostics VM was printed even if if IGNORE_TRACEBACK_FROM_DIAGNOSTICS was set to True (the default) Analysis: This was caused by the refactoring of the fastapi_example/main.py file done in fe9235a Which changed the output used to detect the error to catch Solution: Fix detection string
Antonyjin
pushed a commit
that referenced
this pull request
Nov 19, 2024
Symptom: The CustomError from the diagnostics VM was printed even if if IGNORE_TRACEBACK_FROM_DIAGNOSTICS was set to True (the default) Analysis: This was caused by the refactoring of the fastapi_example/main.py file done in fe9235a Which changed the output used to detect the error to catch Solution: Fix detection string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symptom:
The CustomError from the diagnostics VM was printed even if if IGNORE_TRACEBACK_FROM_DIAGNOSTICS was set to True (the default)
Analysis:
This was caused by the refactoring of the fastapi_example/main.py file done in fe9235a
Which changed the output used to detect the error to catch
Solution:
Fix detection string