Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add yamlfix #705

Merged
merged 2 commits into from
Oct 3, 2024
Merged

feat: add yamlfix #705

merged 2 commits into from
Oct 3, 2024

Conversation

Psycojoker
Copy link
Collaborator

Add yamlfix to uniformise yaml formatting everywhere.

Related ClickUp, GitHub or Jira tickets : ALEPH-180

Self proofreading checklist

  • New code does not duplicate the functions of builtin or popular libraries.

How to test

Just run:

hatch run lint:style
hatch run lint:fmt

@Psycojoker Psycojoker force-pushed the lp-yamlfix branch 2 times, most recently from 1b55c3a to cc1e9e9 Compare October 2, 2024 21:49
@hoh
Copy link
Member

hoh commented Oct 3, 2024

I find the result less readable without the empty lines. What is your opinion on this ?

@Psycojoker
Copy link
Collaborator Author

I find the result less readable without the empty lines. What is your opinion on this ?

It makes sens to keep at least one whiteline when there is one yes, let's do that https://lyz-code.github.io/yamlfix/#whitelines-adjusting

image

@Psycojoker
Copy link
Collaborator Author

Done, I've also added section_whitelines = 2 to match python behavior

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.18%. Comparing base (3c807fa) to head (ec1dde5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #705   +/-   ##
=======================================
  Coverage   62.18%   62.18%           
=======================================
  Files          69       69           
  Lines        6079     6079           
  Branches      643      643           
=======================================
  Hits         3780     3780           
  Misses       2147     2147           
  Partials      152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Psycojoker Psycojoker merged commit 15bd5f5 into main Oct 3, 2024
22 checks passed
@Psycojoker Psycojoker deleted the lp-yamlfix branch October 3, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants