Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add return type to aleph.vm.utils.to_json #704

Merged
merged 1 commit into from
Sep 25, 2024
Merged

feat: add return type to aleph.vm.utils.to_json #704

merged 1 commit into from
Sep 25, 2024

Conversation

Psycojoker
Copy link
Collaborator

Add missing return type type.

Related ClickUp, GitHub or Jira tickets : ALEPH-XXX

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • All new code is covered by relevant tests.

How to test

Just launch mypy (the CI should do it for you)

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.18%. Comparing base (5518086) to head (d77713b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #704   +/-   ##
=======================================
  Coverage   62.18%   62.18%           
=======================================
  Files          69       69           
  Lines        6079     6079           
  Branches      643      643           
=======================================
  Hits         3780     3780           
  Misses       2147     2147           
  Partials      152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoh hoh merged commit f5654c9 into main Sep 25, 2024
22 checks passed
@Psycojoker Psycojoker deleted the lp-add-typing branch September 25, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants