Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Non deterministic teardown #696

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Problem: Non deterministic teardown #696

merged 1 commit into from
Sep 9, 2024

Conversation

olethanh
Copy link
Collaborator

@olethanh olethanh commented Sep 9, 2024

There was a teardown() inside a del
which was triggered by the garbage collection
This resulted in an unclear lifecycle and strange log error since the teardown was already triggered before and made for strange error when running tests

Solution: remove it

There was a teardown() inside a __del__
which was triggered by the garbage collection
This resulted in an unclear lifecycle and strange log error since the teardown was already triggered before
and made for strange error when running tests

Solution: remove it
@olethanh olethanh force-pushed the ol-remove-del-teardown branch from bbf9e28 to 1869982 Compare September 9, 2024 13:32
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.29%. Comparing base (acc2302) to head (1869982).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
- Coverage   62.34%   62.29%   -0.05%     
==========================================
  Files          69       69              
  Lines        6073     6065       -8     
  Branches      638      637       -1     
==========================================
- Hits         3786     3778       -8     
  Misses       2139     2139              
  Partials      148      148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoh hoh merged commit 073eb83 into main Sep 9, 2024
21 of 22 checks passed
@Psycojoker Psycojoker deleted the ol-remove-del-teardown branch September 18, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants