Fix CI slowness and correct execution tests #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #686 +/- ##
==========================================
+ Coverage 61.36% 62.66% +1.30%
==========================================
Files 68 68
Lines 6012 6029 +17
Branches 636 638 +2
==========================================
+ Hits 3689 3778 +89
+ Misses 2169 2101 -68
+ Partials 154 150 -4 ☔ View full report in Codecov by Sentry. |
Solution: This was due to an import in the test app that is somehow very slow but only during testing. Haven't figured out why it is slow, but have implemented a workaround that delay the import so it's not hit during the tests
olethanh
changed the title
olethanh
force-pushed
the
ol-debug-slow-test
branch
from
526645b to
c996f2c
Compare
This was due to as settings contamination which made it runn the FAKE_DATA_PROGRAM instead of the real one Also correct some things that made the test not run (load_update_mesage instead of get_message)
It was the same name as an other workflow which caused issue in github
olethanh
force-pushed
the
ol-debug-slow-test
branch
from
c996f2c to
b23f052
Compare
hoh
reviewed
Aug 29, 2024
olethanh
force-pushed
the
ol-debug-slow-test
branch
from
9d2e2a3 to
9b9c27d
Compare
hoh
reviewed
Aug 29, 2024
Due to change in behaviour of unix_socket.wait_closed
olethanh
force-pushed
the
ol-debug-slow-test
branch
from
21e5f94 to
c9acb74
Compare
nesitor
approved these changes
Sep 2, 2024
Co-authored-by: Hugo Herter <git@hugoherter.com>
olethanh
force-pushed
the
ol-debug-slow-test
branch
from
3d52796 to
15214f4
Compare
olethanh
added a commit
that referenced
this pull request
Oct 17, 2024
…arate partions Jira Ticket ALEPH-238 Similar issue to #682 That was merged inside #686 We have fixed a variation of this alread but this one triggered for additional volumes only Explanation: The prepare step for jailer is failing because it attempt create a hardlink to a file between the CACHE and EXECUTION dir which is not allowed between separate partition Solution: Make a hardlink Similiarly to the previous resolution, we cannot make a symlink as it is not accessible inside the jailer enclave
4 tasks
nesitor
pushed a commit
that referenced
this pull request
Oct 17, 2024
#711) FirecrackerVM drive not working if /var/lib and /var/cache on two separate partions Jira Ticket ALEPH-238 Similar issue to #682 That was merged inside #686 We have fixed a variation of this alread but this one triggered for additional volumes only Explanation: The prepare step for jailer is failing because it attempt create a hardlink to a file between the CACHE and EXECUTION dir which is not allowed between separate partition Solution: Make a hardlink Similiarly to the previous resolution, we cannot make a symlink as it is not accessible inside the jailer enclave
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solve a few issue with the tests:
Self proofreading checklist
Changes
see above
How to test
Everything is in CI