Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve duplicated network issues for ephemeral VMs #680

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

nesitor
Copy link
Member

@nesitor nesitor commented Aug 21, 2024

Problem: If the service restarts, the diagnostic VM fails for network issues.

Solution: Loading already loaded VMs filtering by only persistent ones. Also remove the network interface if exists and re-create it.

nesitor and others added 2 commits August 21, 2024 18:22
@nesitor nesitor requested review from olethanh and hoh August 21, 2024 21:38
@nesitor nesitor self-assigned this Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 61.45%. Comparing base (2f68012) to head (c320752).
Report is 6 commits behind head on main.

Files Patch % Lines
src/aleph/vm/network/interfaces.py 50.00% 5 Missing and 1 partial ⚠️
src/aleph/vm/pool.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #680      +/-   ##
==========================================
+ Coverage   61.44%   61.45%   +0.01%     
==========================================
  Files          68       68              
  Lines        5994     5993       -1     
  Branches      635      633       -2     
==========================================
  Hits         3683     3683              
  Misses       2156     2156              
+ Partials      155      154       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nesitor nesitor merged commit 4aa662b into main Aug 23, 2024
26 of 27 checks passed
@nesitor nesitor deleted the andres-fix_duplicated_network_issues branch August 23, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants