Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Websocked auth for fail user was not returning error #675

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

olethanh
Copy link
Collaborator

Due to a previous refactoring the code wasn't reachable and thus the code only hang if the user was not the correct one

Solution: Code correction

Due to a previous refactoring the code wasn't reachable
and thus the code only hang if the user was not the correct one

Solution: Code correction
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.50%. Comparing base (ff6c119) to head (b4f8e81).
Report is 5 commits behind head on main.

Files Patch % Lines
src/aleph/vm/orchestrator/views/operator.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #675      +/-   ##
==========================================
+ Coverage   61.43%   61.50%   +0.06%     
==========================================
  Files          68       68              
  Lines        5997     6000       +3     
  Branches      635      635              
==========================================
+ Hits         3684     3690       +6     
+ Misses       2158     2156       -2     
+ Partials      155      154       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nesitor nesitor merged commit 2414198 into main Aug 21, 2024
26 of 27 checks passed
@nesitor nesitor deleted the ol_websocket_failure_state branch August 21, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants