Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Branch main could not be tested easily #612

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

hoh
Copy link
Member

@hoh hoh commented May 2, 2024

This deploys the main branch automatically on the staging servers for system testing.

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.81%. Comparing base (c7db4ef) to head (c06fc4c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #612      +/-   ##
==========================================
- Coverage   43.87%   43.81%   -0.07%     
==========================================
  Files          55       55              
  Lines        4978     4978              
  Branches      587      587              
==========================================
- Hits         2184     2181       -3     
- Misses       2677     2680       +3     
  Partials      117      117              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 2, 2024

Failed to retrieve llama text: POST 504:

504 Gateway Time-out


The server didn't respond in time.

This deploys the main branch automatically on the staging servers for system testing.
@hoh hoh force-pushed the hoh-deploy-main-staging branch from 2fd3aa3 to c06fc4c Compare May 2, 2024 19:52
@hoh hoh requested review from olethanh and nesitor May 6, 2024 14:30
@olethanh
Copy link
Collaborator

olethanh commented May 6, 2024

both server are on debian 12? Wouldn't it make sense to have one on ubuntu?

Copy link
Collaborator

@olethanh olethanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I trust you have tested it somehow

on:
push:
branches:
- main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can do it using a tag instead automatically? Just to have better control on it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think automatically would make things easier: we'll always know that the latest version runs there.

@hoh
Copy link
Member Author

hoh commented May 7, 2024

both server are on debian 12? Wouldn't it make sense to have one on ubuntu?

Yes, that would make sense. However, would it then be difficult to know if a bug comes from the OS or from the hosting provider 🤔 ?

@hoh hoh merged commit f311408 into main May 10, 2024
22 of 23 checks passed
@Psycojoker Psycojoker deleted the hoh-deploy-main-staging branch July 24, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants