Skip to content

Commit

Permalink
Fix instance ip4 network stopping (nat)
Browse files Browse the repository at this point in the history
Temporary disable tearing down the network when stopping supervisor
Fix issue of persistent instances running inside systemd controller losing their ipv4 Nat access
upon supervisor restart or upgrade.

Github issue aleph-im/support#9
  • Loading branch information
olethanh committed Jan 23, 2025
1 parent 76c6897 commit 3b2e938
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/aleph/vm/pool.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,11 @@ def setup(self) -> None:
def teardown(self) -> None:
"""Stop the VM pool and the network properly."""
if self.network:
self.network.teardown()
# self.network.teardown()
# FIXME Temporary disable tearing down the network
# Fix issue of persistent instances running inside systemd controller losing their ipv4 nat access
# upon supervisor restart or upgrade.
pass

Check warning on line 88 in src/aleph/vm/pool.py

View check run for this annotation

Codecov / codecov/patch

src/aleph/vm/pool.py#L88

Added line #L88 was not covered by tests

async def create_a_vm(
self, vm_hash: ItemHash, message: ExecutableContent, original: ExecutableContent, persistent: bool
Expand Down

0 comments on commit 3b2e938

Please sign in to comment.