Fix use case where Volume has no mount point either

src/aleph/vm/controllers/firecracker/executable.py

@@ -114,7 +114,11 @@ async def download_kernel(self):
     async def download_volumes(self):
         volumes = []
         # TODO: Download in parallel
-        for volume in self.message_content.volumes:
+        for i, volume in enumerate(self.message_content.volumes):
+            if not volume.name:
+                volume.name = f"unamed_volume_{i}"
+            if not volume.mount:
+                volume.mount = f"/mnt/{volume.name}"
             volumes.append(
                 HostVolume(
                     mount=volume.mount,

src/aleph/vm/storage.py

@@ -372,8 +372,6 @@ async def get_volume_path(volume: MachineVolume, namespace: str) -> Path:
         return await get_existing_file(ref)
     elif isinstance(volume, PersistentVolume | RootfsVolume):
         volume_name = volume.name if isinstance(volume, PersistentVolume) else "rootfs"
-        if not volume.name:
-            volume_name = f"unamed_{uuid.uuid4().hex}"
         if volume.persistence != VolumePersistence.host:
             msg = "Only 'host' persistence is supported"
             raise NotImplementedError(msg)

tests/supervisor/test_execution.py

@@ -271,7 +271,15 @@ async def test_create_execution_volume_with_no_name(fake_message):
         "name": "",
         "size_mib": 1,
     }
-    fake_message["content"]["volumes"] = [volume_with_no_name]
+    volume_with_no_mount = {
+        "comment": "Persistence with no mount name",
+        "mount": "",
+        "parent": None,
+        "persistence": "host",
+        "name": "",
+        "size_mib": 1,
+    }
+    fake_message["content"]["volumes"] = [volume_with_no_name, volume_with_no_mount]
     fake_message = drop_none_recursively(fake_message)
     fix_message_validation(fake_message)