Skip to content

Commit

Permalink
Fix: Firecracker would not start without DNS servers, even when netwo…
Browse files Browse the repository at this point in the history
…rking is disabled.
  • Loading branch information
hoh committed Mar 6, 2024
1 parent 2623acd commit 07d1f6b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/aleph/vm/controllers/firecracker/program.py
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ async def _setup_configuration(
ipv6 = self.get_ipv6()
ipv6_gateway = self.get_ipv6_gateway()

if not settings.DNS_NAMESERVERS:
if settings.ALLOW_VM_NETWORKING and not settings.DNS_NAMESERVERS:
msg = "Invalid configuration: DNS nameservers missing"
raise ValueError(msg)

Expand Down

0 comments on commit 07d1f6b

Please sign in to comment.