Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add instructions for updating user documentation during release #292

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

olethanh
Copy link
Contributor

Related ClickUp, GitHub or Jira tickets : ALEPH-240

Self proofreading checklist

  • [na ] The new code clear, easy to read and well commented.
  • [na] New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • [na] New classes and functions contain docstrings explaining what they provide.
  • [na] All new code is covered by relevant tests.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.82%. Comparing base (b3d00dc) to head (1865179).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #292   +/-   ##
=======================================
  Coverage   39.82%   39.82%           
=======================================
  Files          18       18           
  Lines        2117     2117           
  Branches      257      257           
=======================================
  Hits          843      843           
  Misses       1222     1222           
  Partials       52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the BLUE This PR is simple and straightforward. label Oct 18, 2024
Copy link

This Pull Request introduces changes to the README.md file, adding a new section for updating the user documentation. The changes are limited to the documentation and do not involve modifications to the core functionality or architecture of the project. The addition of this section is unlikely to introduce bugs or have any significant impact on the codebase. The changes are straightforward and can be easily reviewed by a developer familiar with the project's documentation style and tools. Therefore, this PR is categorized as 'BLUE'.

However, please note that even though the changes are categorized as 'BLUE', it is still important to review the PR to ensure the documentation is accurate and clear.

Copy link
Member

@philogicae philogicae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In the generated doc the sub command description were being shortened,
for example:

    allocate: Notify a CRN to start an instance (for...
    confidential: Create (optional), start and unlock a...

Solution:
Vendroize and customize the tool to generate the doc

Switch the char limit from 45 to 1000
It will still only take the first paragraph
@philogicae philogicae merged commit b878d4b into master Oct 23, 2024
18 checks passed
@philogicae philogicae deleted the ol-update-user-docs-instructions branch October 23, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLUE This PR is simple and straightforward.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants