This repository has been archived by the owner on Aug 19, 2020. It is now read-only.
Start kube-keepalived-vip via dumb-init #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Best practice would be to put dumb-init into the ENTRYPOINT and kube-keepalived-vip into CMD. This commit puts both of them into ENTRYPOINT to be backwards compatible with current deployment which overwrite CMD. Fixes aledbf#66 Signed-off-by: Lars Fenneberg <lf@elemental.net>
|
@elemental-lf thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best practice would be to put dumb-init into the ENTRYPOINT and kube-keepalived-vip into CMD. This commit puts both of them into ENTRYPOINT to be backwards compatible with current deployments which overwrite CMD.
I've tested the resulting image as a replacement for a deployment which has been running 0.29 up to now and have found no issues so far. Everything is as expected.
Fixes #66
Signed-off-by: Lars Fenneberg lf@elemental.net