fix(Context.Run): Don't panic on unselected root node #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes regression introduced in 2544d3f. That commit refactored control flow slightly and missed a case where the selected node is an application node but it does not have a Run method. The fix was straightforward: Treat the "if application node" code path as a possible way to fill `node`, and check it again afterwards. Resolves alecthomas#483
abhinav
force-pushed
the
panic-on-empty-run
branch
from
16403e3 to
4e96b85
Compare
alecthomas
approved these changes
Jan 4, 2025
|
Thanks! |
|
Thanks for merging, @alecthomas! |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug introduced in 2544d3f.
That commit refactored control flow slightly and missed a case
where the selected node is an application node but it does not
have a Run method.
The fix was straightforward:
Treat the "if application node" code path as a possible way to fill
node, and check it again afterwards.Resolves #483