Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lexers/cue: support definitions and dollars in field names #935

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

myitcv
Copy link
Contributor

@myitcv myitcv commented Feb 26, 2024

'$' is valid in a bare field name in CUE. It is not special. It happens to be used by convention at the start of field names, but that is about it.

Definitions start with '#'.

Add a "section" of tests that cover the various types of field. There are no errors in new "tests", whereas before (i.e. without the change to the CUE lexer) there would have been.

'$' is valid in a bare field name in CUE. It is not special. It happens
to be used by convention at the start of field names, but that is about
it.

Definitions start with '#'.

Add a "section" of tests that cover the various types of field. There
are no errors in new "tests", whereas before (i.e. without the change to
the CUE lexer) there would have been.
@alecthomas alecthomas merged commit 898d467 into alecthomas:master Feb 26, 2024
2 checks passed
@myitcv myitcv deleted the fix_cue_field_types branch February 26, 2024 21:14
@myitcv
Copy link
Contributor Author

myitcv commented Feb 26, 2024

Thanks for the fast merge of the PR.

Do you have any indication as to when you will be cutting a new version please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants