fix(tray): fix visibility of Passive items

Passive items could still be displayed if `show_all()` is invoked from `tray.cpp` after the individual icon visibility is set.
alebastr · Sep 20, 2021 · dc67bcc · dc67bcc
1 parent 8534175
commit dc67bcc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/modules/sni/item.cpp b/src/modules/sni/item.cpp
@@ -62,6 +62,7 @@ Item::Item(const std::string& bn, const std::string& op, const Json::Value& conf
   event_box.signal_button_press_event().connect(sigc::mem_fun(*this, &Item::handleClick));
   event_box.signal_scroll_event().connect(sigc::mem_fun(*this, &Item::handleScroll));
   // initial visibility
+  event_box.show_all();
   event_box.set_visible(show_passive_);
 
   cancellable_ = Gio::Cancellable::create();

diff --git a/src/modules/sni/tray.cpp b/src/modules/sni/tray.cpp
@@ -35,11 +35,7 @@ void Tray::onRemove(std::unique_ptr<Item>& item) {
 }
 
 auto Tray::update() -> void {
-  if (box_.get_children().empty()) {
-    box_.hide();
-  } else {
-    box_.show_all();
-  }
+  box_.set_visible(!box_.get_children().empty());
   // Call parent update
   AModule::update();
 }