Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes #528

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Misc fixes #528

merged 3 commits into from
Nov 20, 2024

Conversation

skirpichev
Copy link
Contributor

@skirpichev skirpichev commented Nov 13, 2024

  • Update mpz_set_PyLong() signature (return an integer)
  • Bump cibuildwheel to v2.21.3
  • Update src/pythoncapi_compat.h
  • Use PyLong_IsNegative()

Note: first commit taken from #495. I hope that API will be accepted, thus return value for mpz_set_PyLong() will be required. I would prefer include this change here to cleanup #495. @casevh, if you aren't ok with this - I'll remove this commit.

@casevh
Copy link
Collaborator

casevh commented Nov 14, 2024

Is there any dependance on PEP 757? If so, should we wait for PEP 757 to be accepted?

@skirpichev
Copy link
Contributor Author

Is there any dependance on PEP 757?

@casevh, first commit currently is useless. On another hand, it does nothing bad; I think most compilers nowadays will optimize out added branches.

On pros: this will make #495 smaller.

@skirpichev
Copy link
Contributor Author

BTW, different signature for mpz_set_PyLong() will be required also for PyPy support.

@skirpichev
Copy link
Contributor Author

Ok. @casevh, first commit was reverted.

@casevh casevh merged commit 54c1145 into aleaxit:master Nov 20, 2024
11 checks passed
@casevh
Copy link
Collaborator

casevh commented Nov 20, 2024

Thanks.

@skirpichev skirpichev deleted the misc branch November 20, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants