Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Copy address of pointer level #160

Closed
dreamsyntax opened this issue May 31, 2024 · 2 comments
Closed

Feature: Copy address of pointer level #160

dreamsyntax opened this issue May 31, 2024 · 2 comments

Comments

@dreamsyntax
Copy link
Collaborator

For pointers of n depth, you can "Browse memory at" to open the Memory Viewer to this address.

image

Currently there is no way to 'Copy' a particular depth's address. For example, given the below image:
image

If I wanted to copy level 2's address for use in Dolphin's Breakpoint feature I have to manually open this Address edit pane and type it myself in Dolphin, or utilize the "Browse memory at" and then right click -> add to watch -> copy to clipboard rather than hitting ok -> closing the dialog.

This has the potential to be made much simpler by either allowing copying directly from the Address edit pane or adding a dialog option when right clicking an address in the watchlist.

@jahorta
Copy link
Contributor

jahorta commented Jul 7, 2024

So I took a shot at this, but I would like some feedback before making a PR. I implemented a right click menu entry for copying the address, but I am unsure if I put it in a good position in the right click menu. Currently I have it below the copy option (see below), but it might also work below the browse at address option. Thoughts?

When right clicking a non-pointer
Sample copy addresses non-pointer

When right clicking a pointer
Sample Copy Addresses Pointer

@dreamsyntax
Copy link
Collaborator Author

So I took a shot at this, but I would like some feedback before making a PR. I implemented a right click menu entry for copying the address, but I am unsure if I put it in a good position in the right click menu. Currently I have it below the copy option (see below), but it might also work below the browse at address option. Thoughts?

When right clicking a non-pointer
Sample copy addresses non-pointer

When right clicking a pointer
Sample Copy Addresses Pointer

It looks good to me. I see it being an infrequent action. The positioning doesn't matter too much. I'm unclear on what keyboard shortcuts you picked, but that can be adjusted in the PR. You can open a "draft PR" so we can look at your code and try out the changes while its in a state you consider incomplete/not ready to merge.

jahorta added a commit to jahorta/Dolphin-memory-engine that referenced this issue Jul 7, 2024
…widget

Added a right click menu to m_pointerWidget which activates only if an address label is right clicked. It provides a single option (Copy address) which copies the address from that pointer level to clipboard.

ref: aldelaro5#160
jahorta added a commit to jahorta/Dolphin-memory-engine that referenced this issue Jul 7, 2024
…ntry

Added an option (copy address) to the right click menu of a MemWatchWidget. Selecting Copy address on a pointer watch can copy the address at any pointer level to the clipboard. Selecting Copy address on a non-pointer watch will copy the base address of the watch to the clipboard.

ref: aldelaro5#160
jahorta added a commit to jahorta/Dolphin-memory-engine that referenced this issue Jul 7, 2024
…ntry

Added an option (copy address) to the right click menu of a MemWatchWidget. Selecting Copy address on a pointer watch can copy the address at any pointer level to the clipboard. Selecting Copy address on a non-pointer watch will copy the base address of the watch to the clipboard.

ref: aldelaro5#160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants