Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Fix timeoutouts for large file downloads #2984

Open
meain opened this issue Mar 30, 2023 · 0 comments
Open

Fix timeoutouts for large file downloads #2984

meain opened this issue Mar 30, 2023 · 0 comments
Labels
tech-debt Non-feature, non-bug improvements to the codebase. upstream Blocked by a upstream lib / dependency

Comments

@meain
Copy link
Member

meain commented Mar 30, 2023

We have currently set the the timeout for large file downloads to a large value(48 hours) instead of setting it to a 0 value(which would be ideal). This is because when we set the timeout to 0, kiota sets the context with deadline of 0s into the future. This will need an upstream fix microsoft/kiota-http-go#76 .

// FIXME: This should ideally be 0, but if we set to 0, graph
// client with automatically set the context timeout to 0 as
// well which will make the client unusable.
// https://github.com/microsoft/kiota-http-go/pull/71

@meain meain added upstream Blocked by a upstream lib / dependency tech-debt Non-feature, non-bug improvements to the codebase. labels Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tech-debt Non-feature, non-bug improvements to the codebase. upstream Blocked by a upstream lib / dependency
Projects
None yet
Development

No branches or pull requests

1 participant