Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Set the correct timeout for OneDrive client #2282

Closed
vkamra opened this issue Jan 26, 2023 · 1 comment
Closed

Set the correct timeout for OneDrive client #2282

vkamra opened this issue Jan 26, 2023 · 1 comment
Labels
tech-debt Non-feature, non-bug improvements to the codebase.

Comments

@vkamra
Copy link
Contributor

vkamra commented Jan 26, 2023

The OneDrive client is currently using timeout=0 which isn't correct - it can cause issues if the server blips/has an outage for example and cause requests to be stuck.

We need to set the correct timeout here. The concern so far has been that this depends on file size but I believe the amount of data we read in each request is going to be capped (large files are read in chunks). Need to confirm what's happening over the wire and based on that we can set a sensible timeout.

@vkamra vkamra added the tech-debt Non-feature, non-bug improvements to the codebase. label Jan 26, 2023
@meain
Copy link
Member

meain commented Mar 30, 2023

Closing this in favor of #2984 . Should we just stick to a long timeout and close the newer issue as well?

@meain meain closed this as completed Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tech-debt Non-feature, non-bug improvements to the codebase.
Projects
None yet
Development

No branches or pull requests

2 participants