Line too long #424
Merged
Line too long #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made line shorter, its end wasn't readable
Function plot_dF_state had 42 branches, while it is recommended not to have more than 12. The function is structured with clear blocks by logic and documentation. I extracted methods to encapsulate the logical blocks, reducing complexity.
Both methods generate_result and estimate had a bit too many branches. I extracted methods to reduce complexity and make code clearer.
Two functions, extract_u_nk and _get_lambdas had too many branches. Smaller functions were extracted.
Made two readable lines shorter
Made a readable line shorter
The function plot_ti_dhdl had 81 statements, while it is recommended not to have more than 50. I extracted few smaller functions, reducing the length and increasing structure.
The value of mnb is not set in the case of landscape orientation. It was like that even before extracting get_determine_orientation. However, now that this is a separated function, the test fails due to returning an unset variable. This might detect a bigger bug regarding not setting it unintentionally.
_fit_estimators fails on E UnboundLocalError: cannot access local variable 'u_nk' where it is not associated with a value Since the goal is to reduce branches I revert that and extract the more isolated check_estimators_availability instead
This reverts commit f017972.
This reverts commit a1ea9d9.
This reverts commit d2ed7fa.
This reverts commit 7ece0f8.
This reverts commit ea1ecca.
This reverts commit 3a311d4.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #424 +/- ##
=======================================
Coverage 98.78% 98.78%
=======================================
Files 28 28
Lines 1982 1982
Branches 354 354
=======================================
Hits 1958 1958
Misses 2 2
Partials 22 22 ☔ View full report in Codecov by Sentry. |
|
Thanks, @xiki-tempula ! |
evidencebp
added a commit
to evidencebp/pylint-intervention
that referenced
this pull request
Oct 30, 2024
jaclark5
pushed a commit
to jaclark5/alchemlyb
that referenced
this pull request
Nov 15, 2024
* docs\conf.py line-too-long Made line shorter, its end wasn't readable * src\alchemlyb\visualisation\dF_state.py too-many-branches Function plot_dF_state had 42 branches, while it is recommended not to have more than 12. The function is structured with clear blocks by logic and documentation. I extracted methods to encapsulate the logical blocks, reducing complexity. * src\alchemlyb\workflows\abfe.py too-many-branches Both methods generate_result and estimate had a bit too many branches. I extracted methods to reduce complexity and make code clearer. * src\alchemlyb\parsing\namd.py too-many-branches Two functions, extract_u_nk and _get_lambdas had too many branches. Smaller functions were extracted. * src\alchemlyb\parsing\amber.py line-too-long Made two readable lines shorter * src\alchemlyb\parsing\util.py line-too-long Made a readable line shorter * src\alchemlyb\visualisation\ti_dhdl.py too-many-statements The function plot_ti_dhdl had 81 statements, while it is recommended not to have more than 50. I extracted few smaller functions, reducing the length and increasing structure. * Add default value for mnb in get_determine_orientation The value of mnb is not set in the case of landscape orientation. It was like that even before extracting get_determine_orientation. However, now that this is a separated function, the test fails due to returning an unset variable. This might detect a bigger bug regarding not setting it unintentionally. * Fix _fit_estimators extraction _fit_estimators fails on E UnboundLocalError: cannot access local variable 'u_nk' where it is not associated with a value Since the goal is to reduce branches I revert that and extract the more isolated check_estimators_availability instead * Revert "Fix _fit_estimators extraction" This reverts commit f017972. * Revert "Add default value for mnb in get_determine_orientation" This reverts commit a1ea9d9. * Revert "src\alchemlyb\visualisation\ti_dhdl.py too-many-statements" This reverts commit d2ed7fa. * Revert "src\alchemlyb\parsing\namd.py too-many-branches" This reverts commit 7ece0f8. * Revert "src\alchemlyb\workflows\abfe.py too-many-branches" This reverts commit ea1ecca. * Revert "src\alchemlyb\visualisation\dF_state.py too-many-branches" This reverts commit 3a311d4. --------- Co-authored-by: Zhiyi Wu <zwu@exscientia.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.