Add poc changes for #177 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertpl
commented
Oct 3, 2023
poc/flp_generic.py
Outdated
| @@ -658,6 +658,12 @@ class SumVec(Valid): | |||
| JOINT_RAND_LEN = 1 | |||
| OUTPUT_LEN = None # Set by constructor | |||
|
|
|||
| @classmethod | |||
There was a problem hiding this comment.
I choose to this approach, instead of making field a __init__ parameter because
- Follow existing patterns in
vdaf_prio3.pywhere we usingPrio3as a template to createPrio3SumVecetc. SumVec.Fieldis closer to template/generic parameters than instance properties, to me
| @@ -483,6 +510,41 @@ class Prio3HistogramWithLength(Prio3Histogram): | |||
| return Prio3HistogramWithLength | |||
|
|
|||
|
|
|||
| class Prio3SumVecWithMultiproof(Prio3SumVec): | |||
There was a problem hiding this comment.
This is the Prio3SumVec variant with configurable PROOFS parameter.
albertpl
force-pushed
the
poc-prio3-multiproof
branch
2 times, most recently
from
44b4ea8 to
8b74ffc
Compare
| length: Unsigned, | ||
| bits: Unsigned, | ||
| chunk_length: Unsigned, | ||
| num_proofs: Unsigned, |
There was a problem hiding this comment.
One feedback we got in issue 177 is the algorithm identifier needs to commit to the choice of field and number of proofs. I think that means one code point needs to map to a particular choice of field and number of proofs. The current Prio3 does so by including the algorithm identifier in the domain separation tag.
There was a problem hiding this comment.
OK. I just pushed a commit to make it clear that algorithm ID is dependent on (field, num_proofs). Let me know.
albertpl
force-pushed
the
poc-prio3-multiproof
branch
2 times, most recently
from
e880a21 to
71f242a
Compare
* Support multiproofs in Prio3 * Add new Prio3SumVec variant, i.e. Prio3SumVecWithMultiproof, with configuration (field size, number of proofs) * Add with_field class methods to introduce new SumVec with configurable field size
albertpl
force-pushed
the
poc-prio3-multiproof
branch
from
2ee0feb to
e11c788
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#177