Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace before/after Whazzup File URL causes Test function to become inactive or fail #1089

Closed
hdinthkld opened this issue Feb 8, 2024 · 2 comments
Assignees
Labels
Milestone

Comments

@hdinthkld
Copy link

hdinthkld commented Feb 8, 2024

Confirmed with 2.8.12

When entering the URL for the Whazzup file URL users are unable to test the connection if there is whitespace at the beginning:
image

In addition if whitespace is entered after the URL the test fails:
image

Whitespace is not permitted in a URL so it would be preferred if this is automatically cleared out once the user exits the text box.

The online group I'm a member of often receives requests from users who have trouble with this.

@hdinthkld
Copy link
Author

I don't program in Qt but maybe the below is of help:
https://doc.qt.io/qt-5/qstring.html#trimmed

@albar965
Copy link
Owner

albar965 commented Feb 8, 2024

The URL is encoded internally which results all spaces converted to '%20' (and other special characters too). Spaces inside the URL are allowed but trailing or leading should be better trimmed by LNM.

The disabled test button is already fixed in the 3.0.x beta releases.

I'll check all paths and URLs and trim them. I already use the trim function in a lot of places but there are still a few missing.

@albar965 albar965 self-assigned this Feb 8, 2024
@albar965 albar965 added the bug label Feb 8, 2024
@albar965 albar965 added this to the Release 3.0 milestone Feb 8, 2024
albar965 added a commit that referenced this issue Feb 10, 2024
To avoid issues with wrong user input
Closing #1089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants