fix: exit fullscreen model dup error #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 447b47c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
yinshuxun
approved these changes
Mar 14, 2024
|
加上 changeset 发布个新版本吧 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在
aui-code-editor使用中，全屏查看后退出全屏，使用modelUri的实例会因为 model 已存在而创建 model 失败，导致编辑器无法正常使用在对话框动画效果实现之前应该比较难触发
直接返回已有的 model ，里面的 value 会丢，手动 setValue 似乎也不行；怀疑是 model 的 editor 实例也就是对话框里的那个销毁了，model 返回给新实例后也被回收了，才有的退出全屏后有内容然后又没了
所以每次创建新的，都会尝试 dispose 已有的
2024-03-07.16-47-16.mp4