fix list submission for isrcs, puids and echoprints #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug was introduced with 291025c (in version 0.4): Isrcs were always enclosed in [], even if they were already given as a list. So in 0.3 only giving isrcs as lists works and in 0.4 only giving isrcs as single isrc works. Now both should actually work. Signed-off-by: Johannes Dewender <github@JonnyJD.net>
ghost
assigned
JonnyJD
added a commit
to JonnyJD/musicbrainz-isrcsubmit
that referenced
this pull request
Jun 13, 2013
This is broken in python-musicbrainz-ngs 0.4, see alastair/python-musicbrainzngs#113 The workaround doesn't work with pymbngs 0.3.
JonnyJD
added a commit
to JonnyJD/musicbrainz-isrcsubmit
that referenced
this pull request
Jun 13, 2013
This is broken in python-musicbrainz-ngs 0.4, see alastair/python-musicbrainzngs#113 The workaround doesn't work with pymbngs 0.3.
JonnyJD
added a commit
that referenced
this pull request
Jun 14, 2013
see pull-request #113 Signed-off-by: Johannes Dewender <github@JonnyJD.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was introduced with
291025c (in version 0.4):
Isrcs were always enclosed in [], even if they were already given as a
list.
So in 0.3 only giving isrcs as lists works, see #104
and in 0.4 only giving isrcs as single isrc works.
Now both should actually work.