Fix GP Demos #236
Merged
Fix GP Demos #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfixes to correct the GP demos to ensure that they run with the new implementation. Changes include - Update Patsy integration to allow using formulae with LHS
This commit updates several of the demos to work with the new interface to the GP class. In particular, priors and mean functions had to be changed, and some additional calls to the validation methods have been used to replace existing validation code. Note that the MICE code does not currently work with the new interface, as this will require some re-working of the code. This demo has been left unchanged.
Fixes a bug that arises when a LHS is provided for a formula. Corrected the code and added a unit test that catches this situation.
Corrected the gp_demo.R file to correctly use the new prior interface. Verified that the demo runs correctly and can be used as an example script.
Test file to run all demos doesn't currently work due to issues with RNG and plot displays, so I am removing from the index for the time being. This issue will be addressed at another time.
nbarlowATI
approved these changes
Jul 18, 2022
| @@ -55,6 +55,9 @@ def test_GaussianProcess_init(x, y): | |||
| gp = GaussianProcess(x, y, mean="x[0]") | |||
| assert gp._dm.shape == (2, 2) | |||
|
|
|||
| gp = GaussianProcess(x, y, mean="y ~ x[0]") | |||
There was a problem hiding this comment.
I should add a couple of lines to the GPU version of this test, to check that it can also deal with a LHS of a patsy formula (it can, I just checked by hand, but good to have it in the tests too...)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfixes to correct the GP demos to ensure that they run with the new
implementation. Addresses issues #234, #235. Changes include:
gp_demos.pygp_demo.Rexcalibur_workshop_demo.pygp_kernel_demos.pymultioutput_tutorial.py