Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/demos #150

Merged
merged 5 commits into from
Jan 12, 2021
Merged

Feature/demos #150

merged 5 commits into from
Jan 12, 2021

Conversation

edaub
Copy link
Collaborator

@edaub edaub commented Jan 11, 2021

Adds some additional example scripts to the demos directory, including history matching and dimension reduction. Addresses issue #44.

Changes in the PR:

  • Adds demos/historymatch_demos.py example script for history matching.
  • Adds demos/kdr_demos.py example script for dimension reduction.
  • Adds new documentation pages showing the above scripts.

@edaub edaub linked an issue Jan 11, 2021 that may be closed by this pull request
Create simple template examples #44
Closed
@edaub edaub requested a review from nbarlowATI January 11, 2021 16:50
nbarlowATI
nbarlowATI approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@nbarlowATI nbarlowATI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good - both the new demos ran fine, and the descriptions/explanations are good!

@edaub edaub merged commit 2e0200e into devel Jan 12, 2021
@edaub edaub deleted the feature/demos branch January 12, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbarlowATI nbarlowATI nbarlowATI approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create simple template examples
2 participants
@edaub @nbarlowATI