You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment only black is used as a linter, and I think it could be reasonable to introduce ruff as a linter, since it includes all the "good practice" codebase linters in one and easy to add for github CI, and pre-commit hook since it encompasses everything in one command.
@davidwilby just because we were talking about this
Basic Example
One can run it manually to check errors or have it format code automatically, like black does already.
Drawbacks
Running ruff on the code base now would make a lot of changes to a lot of files.
Unresolved questions
No response
Implementation PR
I would be happy to do a PR on that.
Reference Issues
No response
The text was updated successfully, but these errors were encountered:
Thanks @nilsleh. I'm not super opinionated. The main github page only mentions catching and removing unused imports - what other errors can it catch? Generally I'd be a bit hesitant about changing the default linter quite far through a project (and the risk of forgetting to update docs etc).
If you are keen and think the added value is worthwhile, you could just try running ruff and submitting a PR, and we just see what the diff looks like. All the changes would be encapsulated in that PR, so it's not really an issue that many files would be changed.
Summary
At the moment only
black
is used as a linter, and I think it could be reasonable to introduce ruff as a linter, since it includes all the "good practice" codebase linters in one and easy to add for github CI, and pre-commit hook since it encompasses everything in one command.@davidwilby just because we were talking about this
Basic Example
One can run it manually to check errors or have it format code automatically, like
black
does already.Drawbacks
Running
ruff
on the code base now would make a lot of changes to a lot of files.Unresolved questions
No response
Implementation PR
I would be happy to do a PR on that.
Reference Issues
No response
The text was updated successfully, but these errors were encountered: