Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SHM DC #1805

Merged
merged 8 commits into from
Apr 19, 2024
Merged

Remove SHM DC #1805

merged 8 commits into from
Apr 19, 2024

Conversation

jemrobinson
Copy link
Member

@jemrobinson jemrobinson commented Apr 15, 2024 •
edited
Loading

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).
  • You have marked this pull request as a draft and added '[WIP]' to the title if needed (if you're not yet ready to merge).

⤴️ Summary

  • Remove the SHM domain controller
  • Remove the SHM bastion host
  • Remove SHM admin and LDAP passwords
  • Remove SHM identity subnets and network rules
  • Remove firewall rules related to the DC
  • Remove SHM DSC files

🌂 Related issues

Depends on #1772
Closes #1570

🔬 Tests

Tested on a deployment with a pre-existing DC

@jemrobinson jemrobinson mentioned this pull request Apr 15, 2024
Closed
8 tasks
@jemrobinson jemrobinson force-pushed the 1570-remove-shm-dc branch 2 times, most recently from 87da8de to 7494a3b Compare April 17, 2024 13:56
@jemrobinson jemrobinson changed the title [WIP] Remove SHM DC Remove SHM DC Apr 17, 2024
@jemrobinson jemrobinson marked this pull request as ready for review April 17, 2024 13:57
@jemrobinson jemrobinson requested a review from a team as a code owner April 17, 2024 13:58
@jemrobinson jemrobinson requested a review from a team April 17, 2024 13:58
craddm
craddm approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@craddm craddm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jemrobinson jemrobinson merged commit b2fa40e into alan-turing-institute:develop Apr 19, 2024
10 checks passed
@jemrobinson jemrobinson deleted the 1570-remove-shm-dc branch April 19, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craddm craddm craddm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pulumi: replace domain controller with AzureAD proxy
2 participants
@jemrobinson @craddm