iss_24 🔒 auth token check for urbanair #538
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpshelio
added
API
dpshelio
requested review from
jemrobinson,
OscartGiles and
PatrickOHara
as code owners
dpshelio
force-pushed
the
24_api_auth
branch
from
2b7f853 to
4b42312
Compare
harryjmoss
reviewed
Sep 29, 2020
| token_decoded = jwt.decode(token, json.dumps(decode_key), | ||
| audience=f"{azure_directory}/{this_app_id}", | ||
| issuer=iss, | ||
| algorithms=header['alg']) |
There was a problem hiding this comment.
Looks like a couple of lines in this file are causing the travis build to fail on the black --check */ stage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds authentications token check
Type of change
Additional dependencies
python-joseTests
How has the code been tested?
So far.. manually...
Issues fixes
List any issues this closes:
Checklist
Please ensure you have done the following:
Code conforms to the projects style guidelines
New code documented using google docstyle
Updated documentation of any changed code
Any additional dependencies have been added to the appropriate location (e.g.
setup.pyorrequirements.txt)Unit tests written and passing on local database. Tests should prove that fix is effective or new feature works as expected
Code needs to run on the cluster? Tag database administrator in the pull request review to configure.
Reviewer