TLS support #38
Closed
TLS support #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BlackVoid : Sorry, I've accidentally closed this PR by trying to rebase onto upstream master. I have your changes locally, but I can't push to your I've opened a replacement PR at #42. |
Merged
|
No worries, I'll probably create another pr at a later stage with a small fix I didn't have time to do on the TLS/background refresh PR. In short the periodic tasks stop running in case there is an uncaught exception, so I intend to make sure the first load has to succeed for the server to start and after that it just logs any errors. Thank you for merging the PRs 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here comes another PR which adds support for the following:
This is based on the Keycloak PR since I already run it myself and have need for both changes. If there is a willingness to merge this I can update to PR to only contain the above listed changes.