Skip to content

Commit

Permalink
Upgrade: eslint v6
Browse files Browse the repository at this point in the history
  • Loading branch information
aladdin-add committed Jun 24, 2019
1 parent 695db91 commit 5143195
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 11 deletions.
27 changes: 22 additions & 5 deletions lib/rules.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,32 @@
// ------------------------------------------------------------------------------
// Requirements
// ------------------------------------------------------------------------------

const builtInRules = require("eslint/lib/built-in-rules-index");
const eslintVersion = require("eslint/package.json").version;
const { getNonFixableRule } = require("./utils");
const builtinRules = {};

// eslint v6 restructed its codebase
// TODO: this might be unreliable
if (eslintVersion >= "6.0.0") {
const builtin = require("eslint/lib/rules"); // eslint-disable-line node/no-missing-require

for (const [ruleId, rule] of builtin) {
builtinRules[ruleId] = rule;
}
} else {
const builtin = require("eslint/lib/built-in-rules-index"); // eslint-disable-line node/no-missing-require

Object.keys(builtin)
.reduce((acc, cur) => {
acc[cur] = builtin[cur];
return acc;
}, builtinRules);
}

const allRules = {};

Object.keys(builtInRules).reduce((acc, cur) => {
Object.keys(builtinRules).reduce((acc, cur) => {
acc[cur] = getNonFixableRule(cur);
return acc;
}, allRules);


module.exports = allRules;
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@
"devDependencies": {
"@not-an-aardvark/node-release-script": "^0.1.0",
"@types/eslint": "^4.16.6",
"eslint": "^5.13.0",
"eslint": "^6.0.0",
"eslint-config-eslint": "^5.0.1",
"eslint-plugin-autofix": "0.0.4",
"eslint-plugin-eslint-plugin": "^2.0.1",
"eslint-plugin-node": "^8.0.0",
"eslint-plugin-eslint-plugin": "^2.1.0",
"eslint-plugin-node": "^9.1.0",
"eslint-plugin-self": "^1.2.0",
"husky": "^1.3.1",
"mocha": "^5.2.0"
"husky": "^2.4.1",
"mocha": "^6.1.4"
},
"peerDependencies": {
"eslint": ">= 5.0.0"
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/quotes.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
const rule = require("../../../lib/rules").quotes,
RuleTester = require("eslint").RuleTester;

const ruleTester = new RuleTester();
const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 9 } });

ruleTester.run("quotes", rule, {
valid: [
Expand Down

0 comments on commit 5143195

Please sign in to comment.