0.10.0 #27
0.10.0 #27
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 89.07% 92.05% +2.98%
==========================================
Files 7 7
Lines 357 428 +71
==========================================
+ Hits 318 394 +76
+ Misses 39 34 -5 ☔ View full report in Codecov by Sentry. |
| /// **Note:** This method is not really "async", the underlying system call is still blocking. | ||
| /// Having this method as async is just for convenience when using it in async runtime. |
There was a problem hiding this comment.
This is NOT convenient at all. This is in fact very misleading and confusing to call an async function and get runtime blocked!
Consider remove all APIs that are not actually async to prevent such confusion. This will allow users to use Arc<File> in something like tokio::task::spawn_blocking() explicitly preventing runtime blocking.
There was a problem hiding this comment.
Those APIs are discussed in #17, maybe we could continue to discuss them there if needed.
No description provided.