fix miri #25
Merged
fix miri #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsqStephenZhang
commented
Jan 10, 2025
| @@ -725,7 +725,6 @@ mod test { | |||
| } | |||
|
|
|||
| #[test] | |||
| #[cfg_attr(miri, ignore)] | |||
There was a problem hiding this comment.
it has been fixed, so remove the ignore tag
hsqStephenZhang
commented
Jan 10, 2025
| @@ -1363,7 +1363,7 @@ impl<K: Hash + Eq, V, E: OnEvictCallback, S: BuildHasher> RawLRU<K, V, E, S> { | |||
| { | |||
| match self.map.get_mut(KeyWrapper::from_ref(k)) { | |||
There was a problem hiding this comment.
you may refer to https://github.com/jeromefroe/lru-rs/blob/2d18d2d333cee29057a23f065533d3f2b8dc0ae0/src/lib.rs#L1031.
this kind of operation shall all be accessed via pointers than references
hsqStephenZhang
commented
Jan 10, 2025
| .unwrap(); | ||
|
|
||
| self.attach(bks.as_mut()); | ||
| let node = self.map.remove(&old_key).unwrap(); |
There was a problem hiding this comment.
get the actual node by map.remove, so the value shall be valid
hsqStephenZhang
commented
Jan 10, 2025
| }) | ||
| .unwrap(); | ||
|
|
||
| self.attach(bks.as_mut()); |
hsqStephenZhang
commented
Jan 10, 2025
| @@ -1618,6 +1618,7 @@ mod test { | |||
| use rand::{thread_rng, Rng}; | |||
| use std::format; | |||
|
|
|||
| #[cfg_attr(miri, ignore)] | |||
There was a problem hiding this comment.
the loop is costly, just ignore
|
Thank you very much! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix all miri errors in this PR