Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn SchemaSerializer into SchemaRegistry #8

Merged
merged 9 commits into from
Mar 25, 2024

Conversation

MattToast
Copy link
Collaborator

Rename SchemaSerializer to SchemaRegistry. Move Message formatting into a dedicated _Message class. Rename methods. Better error handling.

@MattToast MattToast added the enhancement New feature or request label Mar 22, 2024
@MattToast MattToast self-assigned this Mar 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 80.68182% with 17 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (protodrg@372e152). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             protodrg       #8   +/-   ##
===========================================
  Coverage            ?   84.33%           
===========================================
  Files               ?       71           
  Lines               ?     4418           
  Branches            ?        0           
===========================================
  Hits                ?     3726           
  Misses              ?      692           
  Partials            ?        0           
Files Coverage Δ
smartsim/_core/schemas/dragonRequests.py 97.22% <100.00%> (ø)
smartsim/_core/schemas/dragonResponses.py 100.00% <100.00%> (ø)
smartsim/_core/schemas/utils.py 100.00% <100.00%> (ø)
smartsim/_core/utils/helpers.py 91.96% <ø> (ø)
smartsim/_core/launcher/dragon/dragonSockets.py 75.00% <75.00%> (ø)
smartsim/_core/launcher/dragon/dragonLauncher.py 29.03% <16.66%> (ø)

Copy link
Owner

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One grammar nitpick to go!

smartsim/_core/schemas/utils.py Outdated Show resolved Hide resolved
Copy link
Owner

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like it! LGTM, pending @ankona's approval.

Copy link
Collaborator

@ankona ankona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MattToast MattToast merged commit 97292df into al-rigazzi:protodrg Mar 25, 2024
32 checks passed
@MattToast MattToast deleted the ser-to-reg branch March 29, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants