Treat DragonSteps as a Managed Steps
#6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `DragonLauncher` now maps dragon run settings to a `DragonStep` and regular run settings to a `LoacalStep` to match behavior of existing launchers. The `DragonLauncher` treats `DragonStep`s as managed steps and `LocalStep`s as unmanaged steps. The `DragonStep`s run commands are now tracked natively through the dragon run time and not proxyed through the `proxyable_run_cmd` decorator. Remove unnecessary down casts to dragon specific entities. Unify `connect_to_dragon` code path for main SmartSim process and the telemetry monitor.
Hack "fix" for race condition in telemetry monitor test. This ought to be removed before we officially ship a dragon launcher!
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## protodrg #6 +/- ##
===========================================
Coverage ? 83.79%
===========================================
Files ? 70
Lines ? 4395
Branches ? 0
===========================================
Hits ? 3683
Misses ? 712
Partials ? 0
|
MattToast
commented
Mar 9, 2024
Co-authored-by: Matt Drozt <matthew.drozt@gmail.com>
al-rigazzi
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DragonLaunchernow maps dragon run settings to aDragonStepand regular run settings to aLoacalStepto match behavior of existing launchers.The
DragonLaunchertreatsDragonSteps as managed steps andLocalSteps as unmanaged steps. TheDragonSteps run commands are now tracked natively through the dragon run time and not proxyed through theproxyable_run_cmddecorator.Remove unnecessary down casts to dragon specific entities. Unify
connect_to_dragoncode path for the main SmartSim process and the telemetry monitor.