Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragon iteration two, clean history #5

Merged
merged 14 commits into from
Mar 6, 2024
Merged

Dragon iteration two, clean history #5

merged 14 commits into from
Mar 6, 2024

Conversation

al-rigazzi
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 41.17647% with 30 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (protodrg@c68da95). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             protodrg       #5   +/-   ##
===========================================
  Coverage            ?   84.18%           
===========================================
  Files               ?       70           
  Lines               ?     4420           
  Branches            ?        0           
===========================================
  Hits                ?     3721           
  Misses              ?      699           
  Partials            ?        0           
Files Coverage Δ
smartsim/_core/schemas/dragonRequests.py 97.22% <100.00%> (ø)
smartsim/_core/schemas/dragonResponses.py 100.00% <100.00%> (ø)
smartsim/log.py 96.26% <ø> (ø)
smartsim/_core/control/controller.py 83.98% <0.00%> (ø)
smartsim/_core/generation/generator.py 96.00% <50.00%> (ø)
smartsim/_core/config/config.py 96.03% <66.66%> (ø)
smartsim/_core/launcher/dragon/dragonBackend.py 0.00% <0.00%> (ø)
smartsim/_core/launcher/dragon/dragonLauncher.py 31.90% <37.93%> (ø)

Copy link
Collaborator

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small nits, but otherwise LGTM!!

smartsim/_core/launcher/dragon/dragonBackend.py Outdated Show resolved Hide resolved
conftest.py Outdated Show resolved Hide resolved
smartsim/_core/entrypoints/dragon.py Outdated Show resolved Hide resolved
smartsim/_core/launcher/dragon/dragonBackend.py Outdated Show resolved Hide resolved
smartsim/_core/launcher/dragon/dragonLauncher.py Outdated Show resolved Hide resolved
smartsim/_core/launcher/dragon/dragonLauncher.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more small sanity checks, but otherwise still LGTM on my end!!

smartsim/_core/launcher/dragon/dragonLauncher.py Outdated Show resolved Hide resolved
smartsim/_core/launcher/dragon/dragonLauncher.py Outdated Show resolved Hide resolved
smartsim/_core/launcher/dragon/dragonBackend.py Outdated Show resolved Hide resolved
conftest.py Show resolved Hide resolved
Copy link
Collaborator

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks for making sure we are properly setting everything up and tearing everything down!

@al-rigazzi al-rigazzi merged commit 4f9f72e into protodrg Mar 6, 2024
32 checks passed
@al-rigazzi al-rigazzi deleted the drg_iter_two branch April 24, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants