Skip to content

Commit

Permalink
Set GH_TOKEN environment variable to use Github CLI in workflow (Cray…
Browse files Browse the repository at this point in the history
…Labs#570)

This PR updates the authetication used in the release workflow from a
developer created token to the GH_TOKEN environment variable.

[ reviewed by @MattToast ]
[ committed by @amandarichardsonn ]
  • Loading branch information
amandarichardsonn authored Apr 26, 2024
1 parent f5f2385 commit 7db8490
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ jobs:
password: ${{ secrets.PYPI }}
#repository_url: https://test.pypi.org/legacy/


createPullRequest:
runs-on: ubuntu-latest
steps:
Expand All @@ -135,4 +136,4 @@ jobs:
run: |
gh pr create -B develop -H master --title 'Merge master into develop' --body 'This PR brings develop up to date with master for release.'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GH_TOKEN: ${{ github.token }}
4 changes: 4 additions & 0 deletions doc/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ To be released at some future point in time

Description

- Update authentication in release workflow
- Auto-generate type-hints into documentation
- Auto-post release PR to develop
- Bump manifest.json to version 0.0.4
Expand Down Expand Up @@ -49,6 +50,8 @@ Description

Detailed Notes

- Replace the developer created token with the GH_TOKEN environment variable.
(SmartSim-PR570_)
- Add extension to auto-generate function type-hints into documentation.
(SmartSim-PR561_)
- Add to github release workflow to auto generate a pull request from master
Expand Down Expand Up @@ -132,6 +135,7 @@ Detailed Notes
handler. SmartSim will now attempt to kill any launched jobs before calling
the previously registered signal handler. (SmartSim-PR535_)

.. _SmartSim-PR570: https://github.com/CrayLabs/SmartSim/pull/570
.. _SmartSim-PR561: https://github.com/CrayLabs/SmartSim/pull/561
.. _SmartSim-PR566: https://github.com/CrayLabs/SmartSim/pull/566
.. _SmartSim-PR563: https://github.com/CrayLabs/SmartSim/pull/563
Expand Down

0 comments on commit 7db8490

Please sign in to comment.