v0.3.0 proposal #19
Merged
v0.3.0 proposal #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapleincode
approved these changes
Jul 5, 2017
Use class name as the service name when load serice. PR-URL: #18 Reviewed-By: XadillaX <i@2333.moe>
Refs: nodejs/node#5291 PR-URL: #22 Reviewed-By: Chengqiang Chen <602196490@qq.com> Reviewed-By: Cleverboy32 <wyzhdu@163.com>
XadillaX
force-pushed
the
v0.3.0-proposal
branch
2 times, most recently
from
b91c602 to
ef3001f
Compare
Notable changes
* **Service Loader**
* Use class name as the service name with underline when `get()` and
`getClass()`.
PR-URL: #19
XadillaX
force-pushed
the
v0.3.0-proposal
branch
from
ef3001f to
4b68cef
Compare
XadillaX
added a commit
that referenced
this pull request
Jul 11, 2017
Notable changes
* **Service Loader**
* Use class name as the service name with underline when `get()` and
`getClass()`.
PR-URL: #19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2017-07-11, Version 0.3.0 (Current), @XadillaX
Notable changes
get()andgetClass().Commits
c232d61841] - (SEMVER-MINOR) loader/service: use class name as the service name (Duan Pengfei) #188559ae4ae2] - github: add issue and pull request templates (XadillaX) #22