Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Started Guide Contains Malformed JSON Example #1605

Closed
espresso opened this issue Apr 1, 2022 · 0 comments · Fixed by #1606
Closed

Getting Started Guide Contains Malformed JSON Example #1605

espresso opened this issue Apr 1, 2022 · 0 comments · Fixed by #1606

Comments

@espresso
Copy link
Contributor

espresso commented Apr 1, 2022

🐛 Bug Report

The "Manual Installation" section of the "Getting Started" guide in the docs contains a malformed JSON example.

If you use Expo for Web, you need to add the following underneath the "web" key in app.json "build": { "babel": { "include": [ "@ui-kitten/components" ] }

Note the missing bracket at the end of the JSON block.

To Reproduce

Steps to reproduce the behavior:

  1. Navigate to the Getting Started > Manual Installation guide in the docs
  2. Observe the second yellow block beneath "Manual Installation" > "Install UI Kitten"

Expected behavior

There should be an additional bracket at the end of the JSON block.

For example

If you use Expo for Web, you need to add the following underneath the "web" key in app.json "build": { "babel": { "include": [ "@ui-kitten/components" ] } }

Link to runnable example or repository (highly encouraged)

https://akveo.github.io/react-native-ui-kitten/docs/guides/getting-started#manual-installation

UI Kitten and Eva version

Package Version
@eva-design/eva N/A
@ui-kitten/components 5.1.2

Environment information

Documentation

@espresso espresso changed the title Getting Started Guide Malformed JSON Example Getting Started Guide Contains Malformed JSON Example Apr 1, 2022
greenfrvr pushed a commit that referenced this issue Oct 27, 2022
docs: getting started guide, malformed json example (#1605)

Added missing bracket to JSON example within Getting Started > Manual Installation guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant