fixed _getNodeAncestors (apache#23593)

akvelon · Nov 5, 2022 · 8807c00 · 8807c00
1 parent 5978d37
commit 8807c00
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/learning/tour-of-beam/frontend/lib/pages/tour/controllers/content_tree.dart b/learning/tour-of-beam/frontend/lib/pages/tour/controllers/content_tree.dart
@@ -73,13 +73,14 @@ class ContentTreeController extends ChangeNotifier {
     notifyListeners();
   }
 
-  List<String> _getNodeAncestors(NodeModel node, List<String> ancestors) {
+  List<String> _getNodeAncestors(NodeModel node, List<String> ancestorIds) {
     if (node.parent != null) {
-      ancestors.add(node.parent!.id);
-      return _getNodeAncestors(node.parent!, ancestors);
-    } else {
-      return ancestors.reversed.toList();
+      return _getNodeAncestors(
+        node.parent!,
+        [...ancestorIds, node.parent!.id],
+      );
     }
+    return ancestorIds.reversed.toList();
   }
 
   void _onContentTreeCacheChange() {