-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): freight assembly tables keep resetting to page 1 #3246
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
be359f9
to
fc9fdfd
Compare
After fixing the original bug, I noticed that the page still resets to 1 when you change the type of artifact. The second commit fixes that issue by calculating and setting the expected page when the table first mounts. |
Screen.Recording.2025-01-12.at.2.31.28.PM.mov |
c6a27c0
to
57c15b6
Compare
…sembleFreight component Signed-off-by: Aayush Srivastava <aayushsrivastava.work@gmail.com>
…cted row when it is first mounted Signed-off-by: Aayush Srivastava <aayushsrivastava.work@gmail.com>
981355b
to
7ff94ad
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3246 +/- ##
=======================================
Coverage 52.05% 52.05%
=======================================
Files 295 295
Lines 26695 26695
=======================================
Hits 13895 13895
Misses 12041 12041
Partials 759 759 ☔ View full report in Codecov by Sentry. |
fixes: #2581
RCA:
This problem is also described here: https://stackoverflow.com/a/64211013