Change current time when running under go test #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to pass signer.Verify() even if the certificate expiration date is INVALID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
テスト実行時には、有効期限切れの証明書でもVerifyが通るよう、CurrentTimeにNotAfterの1日前の日時をセットします。テストではない通常実行の場合は、CurrentTimeに現在日時をセットします。
signer.NotAfterそのままでもVerifyは通るのですが、境界値だと通るかどうか不安になってしまうのと、意図をわかりやすくするために、あえてNotAfterの一日前に設定しています。