Update extension with optional columns #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiglszonja
commented
Mar 13, 2023
| @@ -33,7 +33,7 @@ | |||
| 'install_requires': [ | |||
| 'pynwb>=1.3.0', | |||
| 'numpy<1.19.4', | |||
| 'h5py<3' | |||
| 'h5py', | |||
There was a problem hiding this comment.
@bendichter
I couldn't install ndx-photometry with h5py<3, had legacy-install-failure error for it.
The version that this installs with is 3.8.0.
weiglszonja
commented
Mar 13, 2023
Comment on lines
146
to
+149
| - name: frequency | ||
| dtype: float | ||
| doc: voltage frequency in unit hertz | ||
| quantity: '?' |
There was a problem hiding this comment.
I left this optional for now, but feels a duplication with rate of TimeSeries.
There was a problem hiding this comment.
I think this might be referring to the frequency of the alternating current, e.g. 60 Hz in the US and 50 Hz in Europe
There was a problem hiding this comment.
but maybe not, I don't really remember
There was a problem hiding this comment.
I see, is it okay to leave it optional or rollback?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.