-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding angular4 as a peer dependency. #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ng2-dnd is working as expected on my angular 4 project
It will work but npm will warn about a peer dependency missing. If you use npm shrinkwrap, it won't work at all without the peer dependency being set. |
can you merge and release this branch on npm? |
Today evening. |
Hi @vangorra I made merge via command line into the new repo and run Can you explain how can I use version |
@akserg I'm not entirely sure what error you are mentioning. The benefit to this pull request comes when your project makes use of I have setup some examples that demonstrate how this change will help an angular 4 project. The examples demonstrate the following:
|
since the development of this module is stuck at 30th of january and i really needed it for my ng4 project, i published an update on my fork https://github.com/gnucoop/ng2-dnd (ng4 update and es5/es2015/umd bundles generation). the modified version is available on npm as ngx-dnd. if anyone interested, feel free to contribute |
Done. |
Adds support for angular ^4.0.0