Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding angular4 as a peer dependency. #130

Merged
merged 1 commit into from
Apr 4, 2017
Merged

Adding angular4 as a peer dependency. #130

merged 1 commit into from
Apr 4, 2017

Conversation

vangorra
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Adds support for angular ^4.0.0

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ng2-dnd is working as expected on my angular 4 project

@vangorra
Copy link
Contributor Author

It will work but npm will warn about a peer dependency missing. If you use npm shrinkwrap, it won't work at all without the peer dependency being set.

@morocarlo
Copy link

morocarlo commented Mar 28, 2017

can you merge and release this branch on npm?

@akserg
Copy link
Owner

akserg commented Mar 28, 2017

Today evening.

@akserg
Copy link
Owner

akserg commented Mar 28, 2017

Hi @vangorra

I made merge via command line into the new repo and run npm install. The installed version of Angular was 2.4.10, so the bundle's build was based on it.

Can you explain how can I use version ^4.0.0 from the given semver range in "@angular/core": "^2.4.4 || ^4.0.0"?
I have only one idea - update all @angular/... dependencies to version ^4.0.0 such that "@angular/core": "^4.0.0" and etc.

@vangorra
Copy link
Contributor Author

@akserg I'm not entirely sure what error you are mentioning. The benefit to this pull request comes when your project makes use of npm shrinkwrap. Shrinkwrapping locks dependency versions in place, so your build and app will behave predictably even when a dependency introduces a bug in a later minor version.

I have setup some examples that demonstrate how this change will help an angular 4 project.
https://github.com/vangorra/ng2-dnd-examples

The examples demonstrate the following:

  • ng2 - angular 2 application with ng2-dnd where npm shrinkwrap has been used successfully.
  • ng4-with-errors - angular 4 application with ng2-dnd where npm shrinkwrap cannot be used as there are errors about peer dependencies.
  • ng4 - angular 4 application with with ng2-dnd (and this pull request) where npm shrinkwrap has been used successfully.

@trik
Copy link

trik commented Mar 31, 2017

since the development of this module is stuck at 30th of january and i really needed it for my ng4 project, i published an update on my fork https://github.com/gnucoop/ng2-dnd (ng4 update and es5/es2015/umd bundles generation). the modified version is available on npm as ngx-dnd. if anyone interested, feel free to contribute

@akserg akserg merged commit cda6c50 into akserg:master Apr 4, 2017
@akserg
Copy link
Owner

akserg commented Apr 4, 2017

Done.

@akserg akserg mentioned this pull request Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants